docs: Update readme's to include new errors attributes #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-mendoza
commented
Nov 19, 2024
| @@ -182,6 +182,19 @@ Static fields are added to the [Resource](https://opentelemetry.io/docs/concepts | |||
|
|
|||
| Fields that can change during the lifetime of the page are instead added to each span in a [SpanProcessor](https://opentelemetry.io/docs/specs/otel/trace/sdk/#span-processor). | |||
|
|
|||
| #### GlobalErrorsInstrumentationConfig | |||
There was a problem hiding this comment.
Wasn't 100% sure where the attributes would fit in the doc, but I think this makes the most sense. I'm open to moving it though!
jairo-mendoza
commented
Nov 19, 2024
| @@ -201,6 +201,19 @@ Static fields are added to the [Resource](https://opentelemetry.io/docs/concepts | |||
|
|
|||
| Fields that can change during the lifetime of the page are instead added to each span in a [SpanProcessor](https://opentelemetry.io/docs/specs/otel/trace/sdk/#span-processor). | |||
|
|
|||
| #### GlobalErrorsInstrumentationConfig | |||
There was a problem hiding this comment.
Seems like we have 2 README's that are the same, adding in the new info here too
pkanal
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
We have added new attributes to
GlobalErrorsInstrumentation, updated READMEs to reflect that.How to verify that this has the expected result
Check READMEs.