Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha): fix more perms issues #27

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(gha): fix more perms issues #27

merged 1 commit into from
Dec 11, 2023

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Dec 11, 2023

Which problem is this PR solving?

  • The very permissions failures in this PR

Short description of the changes

@lizthegrey lizthegrey changed the title dummy PR to demonstrate fix fix(gha): fix more perms issues Dec 11, 2023
@lizthegrey lizthegrey merged commit 0ee160c into main Dec 11, 2023
0 of 4 checks passed
@lizthegrey lizthegrey deleted the lizf.test branch December 11, 2023 07:17
MikeGoldsmith pushed a commit to honeycombio/.github that referenced this pull request Dec 13, 2023
## Which problem is this PR solving?

- Private repos cannot be monitored by the semantic convention enforcer

## Short description of the changes

See
amannn/action-semantic-pull-request#173 (comment)

however, this by itself isn't enough as per
honeycombio/loadgen#27 - permissions may also
need to explicitly be granted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant