Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(url): fix setting default port 4317 #29

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix(url): fix setting default port 4317 #29

merged 1 commit into from
Jan 8, 2024

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

  • previously the local port was being set, but the url was not updated

Short description of the changes

  • Correctly defaults to using grpc port 4317 if no port specified.

@lizthegrey
fix(url): fix setting default port 4317
2d61375 
previously the local port was being set, but the url was not updated
@lizthegrey lizthegrey requested a review from a team as a code owner December 11, 2023 10:10
kentquirk
kentquirk approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@kentquirk
Copy link
Collaborator

Thanks for all the attention on this. I've been meaning to get back to it and make it a public repo but it's been busy. This gets it a lot closer.

@lizthegrey lizthegrey merged commit aba9026 into main Jan 8, 2024
3 checks passed
@lizthegrey lizthegrey deleted the lizf.fix-default-port branch January 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizthegrey @kentquirk