Skip to content

Commit

Permalink
terraform-provider-aws 3.42.0 supports the aws_cloudwatch_metric_stre…
Browse files Browse the repository at this point in the history
…am resource

See: hashicorp/terraform-provider-aws#19429
(which superseded
hashicorp/terraform-provider-aws#18870).  Which
means we can remove all the clunky run-your-own-forked-provider junk.
Yay!
  • Loading branch information
ismith committed May 21, 2021
1 parent fd6f605 commit 3aeba05
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 33 deletions.
30 changes: 0 additions & 30 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,36 +31,6 @@ exclusive). We've also provided an example of tagging your resources.

## Development

### Forked hashicorp/aws provider
Since the `aws_cloudwatch_metric_stream` resource is [not yet
released](https://github.com/hashicorp/terraform-provider-aws/pull/18870),
you'll need to build a local copy:

```bash
# I assume you have the gh command from github installed; if not, just check out
# the branch in question by hand
gh repo clone hashicorp/terraform-provider-aws
cd terraform-provider-aws
gh pr checkout 18870

make tools
make build # installs to $GOPATH/bin/terraform-provider-aws
```

And configure terraform to use it by putting this in `~/.terraformrc` (change
`/home/USERNAME/go` to match your `$GOPATH`):
```hcl
provider_installation {
dev_overrides {
"hashicorp/aws" = "/home/USERNAME/go/bin"
}
}
```

Now you can `terraform plan`, `terraform apply`, etc as usual. If you run
`terraform init`, it will complain that this is unnecessary given the
`dev_overrides`, but you need it to install the modules.

### Tests
Test cases are in [`tests/`](tests/). To setup:

Expand Down
2 changes: 1 addition & 1 deletion tests/test.bats
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# destroy`.

### BEFORE:
# Configure terraform (to be doc'd in more detail?) and run `terraform apply`.
# Configure terraform and run `terraform apply`.
###

### Run:
Expand Down
4 changes: 2 additions & 2 deletions versions.tf
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
terraform {
# TODO: not sure we need >= 0.13! But it's what we can test against.
# TODO: not sure we need >= 0.13! But it's what we've tested against.
required_version = ">= 0.13"
required_providers {
aws = {
source = "hashicorp/aws"
version = "> 0.0.0" # TODO: pending https://github.com/hashicorp/terraform-provider-aws/pull/18870
version = ">= 3.42.0"
}
}
}

0 comments on commit 3aeba05

Please sign in to comment.