feat: slack channel regex accepts channel id #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 75 75
Lines 5963 5963
=======================================
Hits 4725 4725
Misses 915 915
Partials 323 323 ☔ View full report in Codecov by Sentry. |
jharley
reviewed
Sep 3, 2024
| @@ -27,7 +29,7 @@ func newSlackRecipient() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Description: "The Slack channel or username to send the notification to. Must begin with `#` or `@`.", | |||
There was a problem hiding this comment.
Just noticed this: should probably update this description here, or maybe just remove the "Must begin.." altogether?
There was a problem hiding this comment.
The related doc in docs/resources/slack_recipient.md should get updated to match
jharley
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Updates the Slack channel regex to include channel ids in addition to channels/users beginning with
#or@