Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go): fix go version #546

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore(go): fix go version #546

merged 3 commits into from
Sep 19, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Sep 19, 2024

#545 required an update to "go.mod" such that the go directive went from 1.22 to 1.22.0 in order to appease the compiler.

This was confusing to me, so I opened hashicorp/terraform-plugin-framework#1042 and learned that things had ✨ changed ✨.

Looking at the Go documentation we should be using go get go@1.X when upgrading Go versions, and because the current toolchain directive value will match it is excluded.

For example, the change set in this PR is from running:

$ go get go@1.22
go: upgraded go 1.22.0 => 1.22.7
go: removed toolchain go1.22.7

@jharley jharley added the dependencies Pull requests that update a dependency file label Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (8da3f3b) to head (7a248c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   78.78%   78.78%           
=======================================
  Files          86       86           
  Lines        6124     6124           
=======================================
  Hits         4825     4825           
  Misses        964      964           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review September 19, 2024 18:35
@jharley jharley requested a review from a team as a code owner September 19, 2024 18:35
@jharley jharley merged commit 51eb48e into main Sep 19, 2024
6 checks passed
@jharley jharley deleted the jharley.fix-go branch September 19, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants