Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Convert project name with the same rules as wrangler #14

Merged
merged 1 commit into from
Oct 22, 2023
Merged

fix: Convert project name with the same rules as wrangler #14

merged 1 commit into from
Oct 22, 2023

Conversation

nmemoto
Copy link
Contributor

@nmemoto nmemoto commented Oct 22, 2023

resolve #13

@nmemoto nmemoto mentioned this pull request Oct 22, 2023
Closed
@yusukebe
Copy link
Member

@nmemoto

Super cool! LGTM!

@sor4chi Could you review this?

sor4chi
sor4chi approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. completely works!
thank you!

@yusukebe yusukebe merged commit 6c15448 into honojs:main Oct 22, 2023
@nmemoto nmemoto deleted the convert-project-name-with-the-same-rules-as-wrangler branch October 22, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sor4chi sor4chi sor4chi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to start Cloudflare workers project with capital letters in directory name
3 participants
@nmemoto @yusukebe @sor4chi