Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): make ClientResponse.json() returns Union correctly #1786

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix(client): make ClientResponse.json() returns Union correctly #1786

merged 2 commits into from
Dec 6, 2023

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Dec 6, 2023 •
edited
Loading

Fixes #1783

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@yusukebe yusukebe merged commit 477e763 into main Dec 6, 2023
11 checks passed
@yusukebe yusukebe deleted the fix/client-client-response-json-union branch December 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClientResponse<T>.json() returns never when T is a union type of structurally different objects
1 participant
@yusukebe