Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context): c.json() allows object and returns JSONParsed<T> #1806

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(context): c.json() allows object and returns JSONParsed<T> #1806

merged 2 commits into from
Dec 13, 2023

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Dec 11, 2023 •
edited
Loading

Fixes #1800

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@yusukebe yusukebe mentioned this pull request Dec 11, 2023
Closed
DeanMauro
DeanMauro approved these changes Dec 11, 2023
View reviewed changes
Copy link

@DeanMauro DeanMauro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I tested with

  • Date
  • Arrays of Date
  • Nested objects with Date and varied types

Also tested BigInt and it correctly showed a type error (BigInt can't be stringified).

@yusukebe
Copy link
Member Author

@DeanMauro Thank you for reviewing.

I'll merge it now.

@yusukebe yusukebe merged commit af8d16b into main Dec 13, 2023
11 checks passed
@yusukebe yusukebe deleted the fix/json-c-allows-object branch December 13, 2023 00:01
@MonsterDeveloper MonsterDeveloper mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanMauro DeanMauro DeanMauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON response can't contain Dates
2 participants
@yusukebe @DeanMauro