fix: move c.stream* to helper
#1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sor4chi
force-pushed
the
feat/move-stream-to-helper
branch
from
b53c05f
to
69f30b6
Compare
sor4chi
force-pushed
the
feat/move-stream-to-helper
branch
from
69f30b6
to
039e553
Compare
3 tasks
|
Is this ready to review? |
|
@yusukebe Yes, please. |
|
Hi, @yusukebe |
3 tasks
nakasyou
pushed a commit
to nakasyou/hono
that referenced
this pull request
Jan 13, 2024
* refactor: move streaming helper to `streaming/sse.ts` * feat: add streamSSE's export in streaming handler * feat: move `stream` and `streamText` to streaming helper * chore: add deprecated expression for `c.stream` and `c.streamText` * fix: use `stream` helper in streamSSE * refactor: move `streamText` to `text.ts` * test: add some case to `stream` and `streamText` * test: refactor `streamSSE` case for uniformity * chore: denoify * fix: update jsdoc's deprecated description, simplify `c.stream` and `c.streamText` * fix: match the header notation with that of `streamSSE * chore: denoify * refactor: remove unnecesary export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1843
Author should do the followings, if applicable
yarn denoifyto generate files for Deno