Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx): bump react compat version to 19.0.0-hono-jsx #2963

Merged

Conversation

usualoma
Copy link
Member

#2959
First of all, in the react-19-compat branch, we should bump the version number

@usualoma
Copy link
Member Author

@yusukebe Would you please review?

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (75663ff) to head (1d50730).

Additional details and impacted files
@@               Coverage Diff                @@
##           react-19-compat    #2963   +/-   ##
================================================
  Coverage            94.64%   94.64%           
================================================
  Files                  136      136           
  Lines                13324    13324           
  Branches              2259     2232   -27     
================================================
  Hits                 12610    12610           
  Misses                 714      714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member

@usualoma

Before working on this. I'll create a next branch and merge the PRs regarding the React compact I've already accepted.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@usualoma

I've created the next branch and merged some PRs into it. My plan is the following:

  • Include the React 19 compact things to v4.5.0.
  • First, merging these things to react-19-compat.
  • I'll merge it to next when all is done.

Either way, I'll merge this PR to the react-19-compat now. Thanks!

@yusukebe yusukebe merged commit 01a6190 into honojs:react-19-compat Jun 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants