-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): do not suggest unnecenssary route path #3126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
=======================================
Coverage 95.86% 95.87%
=======================================
Files 137 137
Lines 13510 13514 +4
Branches 2262 2259 -3
=======================================
+ Hits 12952 12956 +4
Misses 558 558 ☔ View full report in Codecov by Sentry. |
hi @yusukebe 1. Not includes neverThis issue is involved only when the middleware is chained by {
"*": never
} & {...} This will also be suggested by hono client as a route. However, this PR does not solve the problem of overriding the handler's schema in the middleware path when defining middleware and handler in the same path. Instead of using 2. Change Generics of createHandler/createMiddlewarePreviously, Path was marked as any by default, so if you did not explicitly mark Path as So I marked it at Since this generics has virtually no effect on the schema, such a change is possible. Anyway, it works as long as it is not |
Maybe the two changes should be in different PRs. |
That is another issue. |
ok @yusukebe |
Don't do that. I'll do it. |
Closes #3122
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code