perf(types): rm conditions to get better performance #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-shaka
force-pushed
the
refactor-ExtractKey
branch
from
b304d3e
to
48c50e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 155 155
Lines 9310 9310
Branches 2759 2730 -29
=======================================
Hits 8917 8917
Misses 393 393 ☔ View full report in Codecov by Sentry. |
yusukebe
changed the title
|
Wow. Great! Thanks to |
yusukebe
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codeInstantiationave dropped by more than 10%（3,438,492->2,997,759)