fix(cors): avoid setting Access-Control-Allow-Origin
if there is no matching origin
#3510
+39
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the codeEven if the
Origin
header of a request does not match a origin specified byorigin
option, CORS middleware always setsAccess-Control-Allow-Origin
header. I don't see this as a serious problem, but in some cases it may unintentionally expose a server setting.References
cors
package seems not to set theAccess-Control-Allow-Origin
if theOrigin
header of a request does not match allowed originsAccess-Control-Allow-Origin
header is missingorigin
option as theAccess-Control-Allow-Origin
if the option does not match theOrigin
header of a request, so changes in this PR would have no particular negative impact