Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Array.prototype.at() to look at the end #3703

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Nov 25, 2024

The size of the bundle is reduced by one ant teardrop.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (76b7109) to head (4240f10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
- Coverage   91.70%   91.70%   -0.01%     
==========================================
  Files         159      159              
  Lines       10162    10158       -4     
  Branches     2981     2830     -151     
==========================================
- Hits         9319     9315       -4     
  Misses        842      842              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe yusukebe changed the title chore: use Array.prototype.at() to look at the end refactor: use Array.prototype.at() to look at the end Nov 26, 2024
@yusukebe
Copy link
Member

@ryuapp

Thanks! Merging.

@yusukebe yusukebe merged commit 190e122 into honojs:main Nov 26, 2024
16 checks passed
@ryuapp ryuapp deleted the use-at branch November 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants