-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove charset
parameter from MIME type of application/json
#3743
Conversation
Thank you for the PR! I think you should change this line too: Line 780 in 8886320
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3743 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 159 159
Lines 10177 10177
Branches 2883 2888 +5
==========================================
- Hits 9336 9335 -1
- Misses 840 841 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
These files may also need to be changed. (Note: there are multiple lines in the same file.) hono/src/middleware/basic-auth/index.ts Line 123 in 47bb23c
Line 780 in 47bb23c
hono/src/middleware/bearer-auth/index.ts Line 106 in 47bb23c
Line 54 in 47bb23c
hono/runtime-tests/lambda/index.test.ts Line 540 in 47bb23c
hono/src/middleware/bearer-auth/index.test.ts Line 403 in 47bb23c
hono/src/validator/validator.test.ts Line 132 in 47bb23c
hono/src/middleware/basic-auth/index.test.ts Line 298 in 47bb23c
|
…an `serveStatic()`)
Thanks for pointing that out! @yusukebe I have addressed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
charset
parameter from MIME type of application/json
charset
parameter from MIME type of application/json
Thanks @SaekiTominaga ! Looks good. I'll merge it now. |
fix #3739
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code