-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hono/context): contentful status code typing #3763
feat(hono/context): contentful status code typing #3763
Conversation
993739f
to
b15db32
Compare
b15db32
to
49f5d3e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 159 159
Lines 10178 10174 -4
Branches 2896 2894 -2
==========================================
- Hits 9336 9332 -4
Misses 841 841
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Hi @askorupskyy Thank you for this PR. I'll also review, but @EdamAme-x, can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@askorupskyy Thanks! Looks good to me. @EdamAme-x Pinging again. Can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late, LGTM.
Thanks! I'll merge this now and include this change in the next patch release since this is |
I would consider this a breaking change and don't think it should have been pushed with a patch release. This change is causing all my routes that respond with a The type errors in my code can easily be fixed by updating my routes to use |
Yeah this is a breaking change, specially since an int value was previously acceptable while now we need to have typed num that is valid for |
Agreed, this is a breaking change. |
Contentful status code
Resolves #1518
All in all, prohibits returning
c.json()
orc.text()
orc.html()
with 101, 204, 205, and 304 status codes.bun run format:fix && bun run lint:fix
to format the code