Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle x-forwarded headers to detect auth url #549

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

divyam234
Copy link
Contributor

@divyam234 divyam234 commented May 28, 2024

@yusukebe this pr fixes #537

Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 22f78e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/auth-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

@divyam234 Thanks! Looks good to me. Merging.

@yusukebe yusukebe merged commit d5ebee9 into honojs:main May 28, 2024
1 check passed
This was referenced May 28, 2024
@beorn
Copy link

beorn commented May 28, 2024

Unfortunately, new Request() does not copy over things like credentials so I get a CSRF error. That's why there's all the additional complexity in the getXForwardedRequest() function I guess.

@beorn
Copy link

beorn commented Jun 10, 2024

So this isn't fixed - we unfortunately need the workaround I described here: #537 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behind a reverse proxy, X-Forwarded-Proto isn't used and plain http is used for the signin action
3 participants