fix(request): use URL instead of path/resolve and add a test

src/request.ts

@@ -3,7 +3,6 @@
 
 import type { IncomingMessage } from 'node:http'
 import type { Http2ServerRequest } from 'node:http2'
-import { resolve } from 'node:path'
 import { Readable } from 'node:stream'
 
 const newRequestFromIncoming = (
@@ -42,13 +41,8 @@ const requestPrototype: Record<string | symbol, any> = {
  },
 
  get url() {
- let path = this[incomingKey]['path']
- if (!path) {
- const originalPath = this[incomingKey].url
- path = /\.\./.test(originalPath) ? resolve(originalPath) : originalPath
- this[incomingKey]['path'] = path
- }
- return `http://${this[incomingKey].headers.host}${path}`
+ const url = `http://${this[incomingKey].headers.host}${this[incomingKey].url}`
+ return /\.\./.test(url) ? new URL(url).href : url
  },
 
  [getRequestCache]() {

test/request.test.ts

@@ -27,7 +27,16 @@ describe('Request', () => {
  } as IncomingMessage)
  expect(req).toBeInstanceOf(global.Request)
  expect(req.url).toBe('http://localhost/foo.txt')
- // Check if cached value is returned correctly
+ })
+
+ it('Should resolve double dots in host header', async () => {
+ const req = newRequest({
+ headers: {
+ host: 'localhost/..',
+ },
+ url: '/foo.txt',
+ } as IncomingMessage)
+ expect(req).toBeInstanceOf(global.Request)
  expect(req.url).toBe('http://localhost/foo.txt')
  })
 })