Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yusukebe,
I saw your post on X (Twiiter) and tried to optimize it.
For performance improvement:
writeHead
instead ofsetHeader
.ReadableStream
toReadable
. (Do not callReadable.fromWeb
)Readable.pipeline
.Response#arrayBuffer
instead ofResponse#text
andBuffer.byteLength
Headers#getSetCookie
since it is already split.In other words, this change reduces the overhead of the handle portion of the body.
incomingMessage => Request => handling => Response => ReadableStream => Readable => outgoingMessage
incomingMessage => Request => handling => Response => ReadableStream => outgoingMessage