Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates in history get greyed out #16

Closed
pahnev opened this issue Dec 4, 2014 · 4 comments
Closed

Dates in history get greyed out #16

pahnev opened this issue Dec 4, 2014 · 4 comments

Comments

@pahnev
Copy link

pahnev commented Dec 4, 2014

I was checking the example project without doing anything to it and noticed the issue.
If you select some date, then change the month and go back all the dates before your selected date are greyed out.

I hope my explanation is clear enough.
Great looking picker btw 👍

Edit: found that this solves the issue but you can't actually select any date before current day.
[self.datePicker setDisableHistorySelection:NO];

Unless you turn on this:
[self.datePicker setDisableHistorySelection:NO];
But that has also issue that when you select a day that is in greyed out because it's in another month you don't get selection.

Edit 2:
And everything except the autoselection is actually fixed here ipodishima@284c337

@pahnev pahnev changed the title Selecting history dates gets disabled Dates in history get greyed out Dec 4, 2014
@hons82
Copy link
Owner

hons82 commented Dec 4, 2014

Actually this should give the possibility to disable selection of history dates

[self.datePicker setDisableHistorySelection:NO];

Is it not working correctly? (Actually I did a commit some hours ago on this project)

@pahnev
Copy link
Author

pahnev commented Dec 8, 2014

Oops made a slight mistake there. Meant to paste for the second code

 [self.datePicker setAutoCloseOnSelectDate:YES];

I see you fixed #15 bug which I mention in my edit also. But the original bug still exists. You can check it when history selection is disabled

[self.datePicker setDisableHistorySelection:YES];

Then you click on a date that is not current date(like date in two weeks), change to next mont(January) and then change the month back. Now you can see that everything before your selected date is considered "history" and cannot be selected anymore.

hons82 added a commit that referenced this issue Dec 9, 2014
This should hopefully fix the issue with having the wrong date as
reference to history/future dates
@hons82
Copy link
Owner

hons82 commented Dec 9, 2014

THX
I didn't noticed that yet. It should be fixed in the actual release

@pahnev
Copy link
Author

pahnev commented Dec 9, 2014

Just checked new commit and it seems to be working as it should 👍

@pahnev pahnev closed this as completed Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants