Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeOnSelectDate not working properly #17

Closed
pahnev opened this issue Dec 9, 2014 · 7 comments
Closed

closeOnSelectDate not working properly #17

pahnev opened this issue Dec 9, 2014 · 7 comments
Labels

Comments

@pahnev
Copy link

pahnev commented Dec 9, 2014

Thought I'd open new issue for this one.

So the issue is that whenever the date is in other than current mont (date is grey) and you try to select that date the picker doesn't close. And obviously that date can't be selected.

I'll attach couple screenshots to show this. Current date is december 9th and user clicks on january 9th.

current date december 9th
try to select january 9th

@pahnev
Copy link
Author

pahnev commented Dec 12, 2014

hons82 added a commit that referenced this issue Dec 12, 2014
Possibility to parameterize selection of selested date
@hons82
Copy link
Owner

hons82 commented Dec 12, 2014

THX. I kind of took your approach to fix it.
I hope I tested all cases.

@hons82 hons82 added the bug label Dec 12, 2014
@pahnev
Copy link
Author

pahnev commented Dec 12, 2014

Thanks, allowSelectionOfSelectedDate is not working if autoClose is on though.

Edit: Seems that my solution doesn't work either... I guess I didn't test that.

@hons82
Copy link
Owner

hons82 commented Dec 12, 2014

Your right... to many options that need to work together.
I just committed a possible fix

@pahnev
Copy link
Author

pahnev commented Dec 12, 2014

Seems to be working and starting to look pretty solid 👍 :)

@pahnev pahnev closed this as completed Dec 12, 2014
@hons82
Copy link
Owner

hons82 commented Dec 13, 2014

Thx a lot 4 your help.
You're now in the contributor list :)

@pahnev
Copy link
Author

pahnev commented Dec 15, 2014

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants