Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to select a year #28

Closed
ivangodfather opened this issue Jun 10, 2015 · 12 comments
Closed

How to select a year #28

ivangodfather opened this issue Jun 10, 2015 · 12 comments
Assignees

Comments

@ivangodfather
Copy link

Hi, i want to use this calendar also for birthdays, theres a way to select a specific year without having to pass thoroug all the months?

@hons82
Copy link
Owner

hons82 commented Jun 10, 2015

I'm not sure what you need.
If you just want to jump to a date in future change the date before launching it

self.datePicker.date = self.curDate;

there is no button or swipe or something if the calendar is open to switch year directly.

@ivangodfather
Copy link
Author

Yeah, thats what i'm talking about, if i need to use it for select a birthday, so choosing past years like 1980 takes so long

@hons82
Copy link
Owner

hons82 commented Jun 10, 2015

Currently I'm not planing such a feature.
It's more a graphical challenge then a coding one.

Need to think about this

@hons82 hons82 self-assigned this Jun 10, 2015
hons82 added a commit that referenced this issue Jul 1, 2015
+Travis and Coveralls integration
Bump to 1.2.0
@hons82
Copy link
Owner

hons82 commented Jul 1, 2015

In V1.2.0 you'll find the solution to select the year faster.

@hons82 hons82 closed this as completed Jul 1, 2015
@ErwannRobin
Copy link

Hello,
First, thank you a lot for this component, we use it @blablacar as our main date picker, and it's awesome. But we customized it a little bit (colors + customs images), and it doesn't fit well with the new year selection method.
Could it be optional ?

@hons82 hons82 reopened this Aug 5, 2015
@hons82
Copy link
Owner

hons82 commented Aug 5, 2015

Hi @diwann,
Optional... Shouldn't be a big problem... Would it be enough to just hide the year selection buttons? Or is there any other recent change that doesn't fit?

I wasn't aware that @blablacar is using it. Nice. Could you add it here, as Apps that use this control.

@ErwannRobin
Copy link

Thanks, just hiding the year selection buttons would be really enough.
we just changed the asset to be more consistent with the overall design.

FYI, here is what we have right now:
ios simulator screen shot 5 aout 2015 10 40 38

and here is what we see with the year selection button:
ios simulator screen shot 5 aout 2015 10 38 54

Concerning cocoacontrols, I had already tried but I can't add it to the users page because our app is not available on the usa and because cocoacontrols require an itunes url like : https://itunes.apple.com/us/app/*
so this : https://itunes.apple.com/gb/app/id341329033 does not work ...

hons82 added a commit that referenced this issue Aug 5, 2015
@hons82
Copy link
Owner

hons82 commented Aug 5, 2015

I've added the switch in the latest commit, but not fully tested.
This week I'm a bit short in time, so I don't know if I'm able to provide a new pod

@ErwannRobin
Copy link

don't worry, no hurry
gonna test it tomorrow.

@ErwannRobin
Copy link

ok, I found a small typo bug when selecting a previous month.
And the swipe recongnizer was allowing yearly swipe even with _disableYearSwitch enabled.
( I made a PR : #34 )

but I also found a strange bug : the first swipe on the calendar is showing something strange, which was not the case before, but I wasn't able to understang why. Here is a video to explain it :
-> https://www.youtube.com/watch?v=i6viXJDSC8U
(with slow animations turned on to show the glitch better)

@hons82
Copy link
Owner

hons82 commented Aug 6, 2015

Thanks 4 the PR... I'll check it out as soon as I can.

About this bug... Wow... Wasn't aware of that... I'll check that too

Sent from my iPad

On 06 Aug 2015, at 11:52, Erwann Robin notifications@github.com wrote:

ok, I found a small typo bug when selecting a previous month.
And the swipe recongnizer was allowing yearly swipe even with _disableYearSwitch enabled.
( I made a PR : #34 )

but I also found a strange bug : the first swipe on the calendar is showing something strange, which was not the case before, but I wasn't able to understang why. Here is a video to explain it :
-> https://www.youtube.com/edit?o=U&video_id=i6viXJDSC8U


Reply to this email directly or view it on GitHub.

@hons82 hons82 added the bug label Aug 20, 2015
hons82 added a commit that referenced this issue Aug 25, 2015
This should solve the layout problem in issue #28
@hons82
Copy link
Owner

hons82 commented Aug 25, 2015

I guess I found the error.
Just pushed the latest changes

@hons82 hons82 closed this as completed Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants