Skip to content

Removing deprecated attributes from HTML table snippet #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robingrindrod opened this issue Oct 19, 2016 · 2 comments
Closed

Removing deprecated attributes from HTML table snippet #804

robingrindrod opened this issue Oct 19, 2016 · 2 comments

Comments

@robingrindrod
Copy link
Contributor

The HTML table snippet in UltiSnips/html.snippets has the border, cellspacing and cellpadding attributes. The cellspacing and cellpadding attributes have both been deprecated in the HTML5 spec. As far as I can see, the border attribute does not seem to deprecated according to the official spec but the Mozilla wiki seems to think it is. Removing it would bring it in line with pull request #314 and I'd guess the attribute is not widely used.

I'll create a pull request with them all removed as this would be my own personal preference but I'd love to hear other people's opinions.
robingrindrod added a commit to robingrindrod/vim-snippets that referenced this issue Oct 19, 2016
@robingrindrod
Remove unused attributes from HTML table snippet
d92f70a 
This removes the border, cellspacing and cellpadding attributes from the
HTML table snippet.

See issue honza#804
@robingrindrod robingrindrod mentioned this issue Oct 19, 2016
Merged
@sedrubal
Copy link
Contributor

sedrubal commented Jan 4, 2017

Totally agree. Please replace XHTML snippets with HTML5

@lpil
Copy link
Contributor

lpil commented Jan 4, 2017

Seems this issue has been fixed.

I think it'd be good to replace XHTML with HTML5, I'd be very happy to merge that PR.

@lpil lpil closed this as completed Jan 4, 2017
@sedrubal sedrubal mentioned this issue Jan 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robingrindrod @sedrubal @lpil