Skip to content

Corrections to Fortran snippets #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2016
Merged

Corrections to Fortran snippets #783

merged 5 commits into from
Nov 26, 2016

Conversation

Aster89
Copy link
Contributor

@Aster89 Aster89 commented Sep 18, 2016

I corrected some error in the open, close, write and read statements.
I also moved the doc snippet at the beginning, just for sake of order 😄 . I've also turned everything uppercase but the default values.

Copy link
Contributor Author

@Aster89 Aster89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the fortran.snippet file, putting the doc snippet at the very first lines, and turning every command upper case. This can be just what I like, but there are commits in which I made some correction.
I also wrote the gdscript.snippet file, with all functions of GDscript, the scripting language used by Godot game engine. This last file is HUGE, maybe it could be split in tens of files.

@lpil
Copy link
Contributor

lpil commented Sep 25, 2016

Could you make a separate pull request for the new snippets please? :)

@Aster89
Copy link
Contributor Author

Aster89 commented Sep 25, 2016

Yes. Make one pull request for both modifications was not what I wanted to do, but I'm new to both GitHub and Git, so I apologize 😌. I'll fix things in a moment (moment ~ 60min).

@lpil
Copy link
Contributor

lpil commented Sep 25, 2016

No problem! If delete the file in a new commit on the same branch and then push it to github that will be fine :)

I'm trying to make separate branches for commits related to different snippet files. This commit only affects fortra.snippets.
@Aster89 Aster89 closed this Sep 25, 2016
@Aster89
Copy link
Contributor Author

Aster89 commented Sep 25, 2016

I moved everything Godot-related from this branch to another one, made a new pull request where I removed Fortran-related edits.

@Aster89 Aster89 reopened this Sep 25, 2016
Aster89 added 3 commits September 28, 2016 15:24
Modified the arr snippets for array in such a way that the second tabstop can be used to remove the allocatable attribute.
I'm going to fix a problem with the tabular environment of tex.snippets
Corrected the tabular snippet (also the one in the table snippet) in order to get the correct number of ampersands even for a non-central first column
@Aster89
Copy link
Contributor Author

Aster89 commented Nov 6, 2016

Corrected a problem of the tabular (also the one in the table) snippet of tex.snippet. The problem was that a l or r as first column type instead of c inserted one extra (wrong) ampersand.

@lpil lpil merged commit f5ba6cd into honza:master Nov 26, 2016
@lpil
Copy link
Contributor

lpil commented Nov 26, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants