DBus reason of closing

[antonshkurenko]

Please, do not ignore this value here:

notify-rust/src/xdg/dbus_rs.rs

Line 233 in 3ab49e7

if let (&MessageItem::UInt32(nid), &MessageItem::UInt32(_)) = (&items[0], &items[1]) {

According to the spec: https://specifications.freedesktop.org/notification-spec/latest/ar01s09.html

The second param it's the only way to handle click on notification itself

[hoodie]

oh cool, thanks for pointing this out, I hadn't noticed that yet

[hoodie]

@tonyshkurenko how about this?

[hoodie]

actually, since you mention "The second param it's the only way to handle click on notification itself" what Desktop environment are you using? because the under KDE at least clicking on the notification triggers the "default" action".

[antonshkurenko]

I tested on xfce4 and gnome. Thanks for your help!

[hoodie]

thank you for pointing this out

[antonshkurenko]

Could you please also export ActionResponse type, because it's not visible outside, if you want to use handle_action method

error[E0603]: module `xdg` is private
   --> src/notifier.rs:415:76
    |
415 |                     notify_rust::handle_action(uid, |action: &notify_rust::xdg::ActionResponse| {
    |                                                                            ^^^ private module
    |
note: the module `xdg` is defined here
   --> /home/parallels/.cargo/registry/src/github.com-1ecc6299db9ec823/notify-rust-4.5.0/src/lib.rs:153:45
    |
153 | #[cfg(all(unix, not(target_os = "macos")))] mod xdg;
    |                                             ^^^^^^^^

[hoodie]

could you post the code you tried please?

[hoodie]

also: if you like you could open a PR that fixes that

[antonshkurenko]

I will file a PR then :)

[antonshkurenko]

Regarding code I've tried, I simplified it a bit, but generally it's:

notify_rust::handle_action(uid, |action: &notify_rust::xdg::ActionResponse| {
    match action {
        notify_rust::xdg::ActionResponse::Custom(key) => ...,
        notify_rust::xdg::ActionResponse::Closed(reason) => ...,
    }
});

After PR it's possible now to do:

notify_rust::handle_action(uid, |action: &notify_rust::ActionResponse| {
    match action {
        notify_rust::ActionResponse::Custom(key) => ...,
        notify_rust::ActionResponse::Closed(reason) => ...,
    }
});

[hoodie]

I hadn't realized this at the time, but why do you even use notify_rust::handle_action? there is .wait_for_action()
I was even thinking about deprecating the free function api, is there any good reason not to?