chore: dockerfile.example #505
Conversation
Ensure the image contains trusted CA certificates so the app can establish secure HTTPS connections to AWS services. Without them, TLS handshakes fail with **x509: certificate signed by unknown authority**: `failed to check if infra exists: operation error SQS: GetQueueUrl, exceeded maximum number of attempts, 3, https response error StatusCode: 0, RequestID: , request send failed, Post "https://sqs.eu-west-1.amazonaws.com/": tls: failed to verify certificate: x509: certificate signed by unknown authority`
#482) * chore(build): Copy go mod files first to leverage Docker layer caching for dependencies * chore(build): reorder WORKDIR command
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the production Dockerfile by renaming it to Dockerfile.example and adding clear warnings that it's for reference only. The change encourages users to use the official hookdeck/outpost Docker image instead of building their own.
- Renamed
build/Dockerfiletobuild/Dockerfile.example - Added comprehensive warning comments about production usage
- Updated the Dockerfile with improved multi-stage build and proper entrypoint handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build/Dockerfile.example | New reference-only Dockerfile with warnings and improved build process |
| build/Dockerfile | Removed original production Dockerfile |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| COPY --from=0 /app/bin/outpost-migrate-redis /usr/local/bin/outpost-migrate-redis | ||
|
|
||
| # Copy entrypoint script | ||
| COPY --from=0 /app/build/entrypoint.sh /usr/local/bin/entrypoint.sh |
There was a problem hiding this comment.
The entrypoint script is copied but there's no verification that it exists or is executable. Consider adding a RUN command to make it executable: RUN chmod +x /usr/local/bin/entrypoint.sh
| COPY --from=0 /app/build/entrypoint.sh /usr/local/bin/entrypoint.sh | |
| COPY --from=0 /app/build/entrypoint.sh /usr/local/bin/entrypoint.sh | |
| RUN chmod +x /usr/local/bin/entrypoint.sh |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
i don't think this is necessary because we're already executing sh entrypoint.sh as a shell script; with that in mind, given this is an example Dockerfile, we can iterate on this later if necessary but let's let the users share their input with us if this is a problem.
|
@alexluong - looked okay to me, but copilot has added a couple of comments. |
3 participants
This PR effectively deprecates our previous
build/Dockerfile->build/Dockerfile.exampleand clarify that it should only be used as a reference since we do not use that Dockerfile for production usage.