Skip to content

Commit

Permalink
refactor(nan): convert classes to using nan
Browse files Browse the repository at this point in the history
This is the first step towards making all of these classes/methods
asyncrhonous. Everything was converted to using nan and nan types,
a number of crusty files were removed, the style cleaned up, as
well as a headers clean.
  • Loading branch information
mbroadst committed Mar 29, 2015
1 parent 9fed476 commit f162e62
Show file tree
Hide file tree
Showing 20 changed files with 2,173 additions and 2,787 deletions.
14 changes: 6 additions & 8 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@
'target_name': 'libvirt',
'product_prefix': 'lib',
'sources': [
'src/worker.cc',
'src/node_libvirt.cc',
'src/event_impl.cc',
'src/domain.cc',
'src/error.cc',
'src/hypervisor.cc',
'src/error.cc',
'src/worker.cc',
'src/interface.cc',
'src/network.cc',
'src/network_filter.cc',
'src/node_device.cc',
'src/secret.cc',
'src/storage_pool.cc',
'src/storage_volume.cc',
'src/stream.cc',
# 'src/domain.cc',
],
'include_dirs' : [
"<!(node -e \"require('nan')\")"
Expand All @@ -29,9 +27,9 @@
'<!@(pkg-config --libs libvirt)'
]
},
'cflags': [
'<!@(pkg-config --cflags libvirt)'
],
'cflags': [
'<!@(pkg-config --cflags libvirt)'
],
}]
]
}
Expand Down
10 changes: 8 additions & 2 deletions src/error.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@
#ifndef SRC_ERROR_H_
#define SRC_ERROR_H_

#include "node_libvirt.h"
#include <nan.h>

#include <libvirt/libvirt.h>
#include <libvirt/virterror.h>

using namespace v8;
using namespace node;

namespace NodeLibvirt {

class Error : ObjectWrap
class Error : public ObjectWrap
{
public:
static void Initialize();
Expand Down
241 changes: 0 additions & 241 deletions src/event_impl.cc

This file was deleted.

67 changes: 0 additions & 67 deletions src/event_impl.h

This file was deleted.

Loading

0 comments on commit f162e62

Please sign in to comment.