Skip to content

Commit

Permalink
Don't set as-user since not needed for workspace slack apps (#206)
Browse files Browse the repository at this point in the history
  • Loading branch information
lkysow authored Nov 22, 2017
1 parent acdf771 commit 76b78c9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion server/events/webhooks/slack_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ func (d *DefaultSlackClient) ChannelExists(channelName string) (bool, error) {
func (d *DefaultSlackClient) PostMessage(channel string, applyResult ApplyResult) error {
params := slack.NewPostMessageParameters()
params.Attachments = d.createAttachments(applyResult)
params.AsUser = true
params.EscapeText = false
_, _, err := d.Slack.PostMessage(channel, "", params)
return err
Expand Down
4 changes: 2 additions & 2 deletions server/events/webhooks/slack_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestPostMessage_Success(t *testing.T) {
},
},
}}
expParams.AsUser = true
expParams.AsUser = false
expParams.EscapeText = false

channel := "somechannel"
Expand Down Expand Up @@ -137,7 +137,7 @@ func TestPostMessage_Error(t *testing.T) {
},
},
}}
expParams.AsUser = true
expParams.AsUser = false
expParams.EscapeText = false

channel := "somechannel"
Expand Down

0 comments on commit 76b78c9

Please sign in to comment.