-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack integration #199
Slack integration #199
Conversation
This reverts commit 3be7f8c.
Refactor webhooks
Also renamed Concrete -> Default, Exist -> Exists
Slack integration
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 63.54% 63.91% +0.37%
==========================================
Files 35 38 +3
Lines 1986 2123 +137
==========================================
+ Hits 1262 1357 +95
- Misses 683 716 +33
- Partials 41 50 +9
Continue to review full report at Codecov.
|
@lkysow just wondering, shouldn't this PR also include the vendored dependencies and updated Gopkg.lock? |
Circle CI always fetches them. Might be a bad idea: https://github.com/hootsuite/atlantis/blob/master/.circleci/config.yml#L13 |
Great stuff guys - if you include some info around how to use/set-this-up I can open a PR with changes to the Readme. Cheers |
@nadavshatz yep, tracking that in #200. I found a couple things we need to fix first. Right now, we need the slack bot user to join the channel before it can post messages to it so need to add that. |
No description provided.