Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set as-user since not needed for workspace slack apps #206

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Don't set as-user since not needed for workspace slack apps #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion server/events/webhooks/slack_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ func (d *DefaultSlackClient) ChannelExists(channelName string) (bool, error) {
func (d *DefaultSlackClient) PostMessage(channel string, applyResult ApplyResult) error {
params := slack.NewPostMessageParameters()
params.Attachments = d.createAttachments(applyResult)
params.AsUser = true
params.EscapeText = false
_, _, err := d.Slack.PostMessage(channel, "", params)
return err
Expand Down
4 changes: 2 additions & 2 deletions server/events/webhooks/slack_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestPostMessage_Success(t *testing.T) {
},
},
}}
expParams.AsUser = true
expParams.AsUser = false
expParams.EscapeText = false

channel := "somechannel"
Expand Down Expand Up @@ -137,7 +137,7 @@ func TestPostMessage_Error(t *testing.T) {
},
},
}}
expParams.AsUser = true
expParams.AsUser = false
expParams.EscapeText = false

channel := "somechannel"
Expand Down