Native SSL Support #233
Merged
Native SSL Support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new flags for atlantis server: --ssl-key-file for the key --ssl-cert-file for the server and CA certs You either need to use both or neither. You'll get an error if you accidentally use only one. Currently defaults to non-SSL mode. I think you could make a good argument for SSL by default but since that would be a breaking change I left it for the maintainers to decide. Removed docs for setting up an NGINX frontend.
lkysow
force-pushed
the
retailnext-native-ssl
branch
from
98a11cb
to
a02913e
Compare
lkysow
force-pushed
the
retailnext-native-ssl
branch
from
a02913e
to
2b9f42d
Compare
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 63.78% 63.97% +0.18%
==========================================
Files 38 38
Lines 1759 1757 -2
==========================================
+ Hits 1122 1124 +2
+ Misses 587 583 -4
Partials 50 50
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new flags
ssl-key-fileandssl-cert-fileto enable Atlantis to serve over SSL natively instead of going through an NGINX proxy.Finishes up #226 by @natemueller