Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DisplayStrings_ko.properties #4

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

wonsiks
Copy link
Contributor

@wonsiks wonsiks commented Dec 8, 2020

No description provided.

@hope366
Copy link
Owner

hope366 commented Dec 8, 2020

Hi, @wonsiks san. Thank you for posting the pull request.
It seems to be a correction about Korean notation, so
java -jar -Duser.language=Korean lizzie-improved-v1.9.jar
I tried. Even though I specified Korean, the UI is displayed in English. This is the same before and after applying the PR.
I have little knowledge of programming, so I'm not sure.
Can you tell us the nature of this PR?

@wonsiks
Copy link
Contributor Author

wonsiks commented Dec 8, 2020

@hope366 Yes, it's for Korean notation.
I guess you can see only in Japanese and English because of OS language.
I also can see in Korean and English even when I start lizzie with Japanese option.
Actually this pull request is not translated by myself but other Korean user translated.
This pull request will help Korean people to see better translated lizzie.
20201209_084507
20201209_084544
20201209_084606

@hope366
Copy link
Owner

hope366 commented Dec 9, 2020

Thank you for pasting the screenshot and explaining it in an easy-to-understand manner.
Unfortunately I can't read Korean so I can't understand what the screenshots are.
Also, the content of the PR is like a cipher, so I don't know what kind of modification was made.
Has the operability improved considerably after actually using lizzie?
If so, I would like to incorporate the idea into the Japanese version.

@hope366 hope366 merged commit 3ab2501 into hope366:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants