Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform 533 - Edit Forms in Puente Collect #472

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

jamesgiegerich94
Copy link
Contributor

Description of proposed changes

What does this pull request accomplish? Why should it be integrated?

Checklist

Put an x in the boxes that apply.

  • My lint and unit tests pass locally with my changes
  • I have added tests that prove my changes work (if applicable)
  • I have added or updated necessary documentation (if appropriate)

Additional comments

Is there anything else you want us to know?

@gitguardian
Copy link

gitguardian bot commented Mar 8, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 03549bb app.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Owner

@hopetambala hopetambala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesgiegerich94 do you know how to implement a cloud-code function?

Comment on lines 104 to 111
postIdentificationForm(postParams).then((surveyee) => {
setSurveyee(surveyee);
submitAction();
}, () => {
// perhaps an alert to let the user know there was an error
setSubmitting(false);
// setSubmissionError(true);
});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesgiegerich94 this is where we use the updateObject function

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hopetambala I didn't know how, but Joey got me going in the right direction

@jamesgiegerich94 jamesgiegerich94 changed the title Platform 533 - Edit Forms in Puente Collect - WIP Platform 533 - Edit Forms in Puente Collect Apr 8, 2022
@hopetambala hopetambala changed the base branch from dev to master October 26, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants