lib/Horde/Crypt/Pgp/Keyserver.php: Newer keyserver implementations UR… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L-encode the body returned by index lookups. To handle this gracefully, we first check whether the returned body is URL-encoded and if so, urldecode() it.
sunweaver
commented
Nov 17, 2022
| $output = urldecode($body); | ||
| } else { | ||
| $output = $body; | ||
| } |
There was a problem hiding this comment.
Please note that this should work in theory, but fails sometimes in reality.
I have reverted this on my running instance back to
- $output = $response->getBody();
+ $body = $response->getBody();
+ $output = urldecode($body);
And I only use a keyserver that returns results urlencoded.
|
Weird. And these servers still send the response as text/plain? Do they differ in any other HTTP response headers from those that don't urlencode the body? |
|
I use https://keys.openpgp.org/, feel free to test it with that. Unfortunately, I haven't tested this any further. I simply saw that the body came in urlencoded, so I added the urldecode() call and tadaaa... the key retrieval worked again (together with the 16-digit PR #6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…L-encode the body returned by index lookups.
To handle this gracefully, we first check whether the returned body is
URL-encoded and if so, urldecode() it.