Skip to content

Commit

Permalink
change scope of whenExpression (#65)
Browse files Browse the repository at this point in the history
* feat: expose flag

Signed-off-by: xuzhu-591 <zhuxu591@163.com>

* fix: tekton pipeline resources

Signed-off-by: xuzhu-591 <zhuxu591@163.com>

* fix: review

Signed-off-by: xuzhu-591 <zhuxu591@163.com>

* bump horizon to 2.2.10

Signed-off-by: xuzhu-591 <zhuxu591@163.com>

---------

Signed-off-by: xuzhu-591 <zhuxu591@163.com>
Co-authored-by: xuzhu-591 <zhuxu591@163.com>
  • Loading branch information
xuzhu-591 and xuzhu-591 authored Jul 28, 2023
1 parent 9e853c3 commit c1a9d81
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/horizon/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A CICD DevOps Platform

type: application

version: 2.2.9
version: 2.2.10
appVersion: v2.5.0
dependencies:
- name: common
Expand Down
2 changes: 1 addition & 1 deletion charts/tektoncd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: tektoncd

type: application

version: 2.1.2
version: 2.1.3

appVersion: 0.28.0

Expand Down
10 changes: 8 additions & 2 deletions charts/tektoncd/templates/tekton-pipelines/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ data:
enable-api-fields: "stable"
# Setting this flag to "true" scopes when expressions to guard a Task only
# instead of a Task and its dependent Tasks.
scope-when-expressions-to-task: "false"
scope-when-expressions-to-task: "{{ .Values.featureFlags.scopeWhenExpressionsToTask }}"

---
# Copyright 2021 The Tekton Authors
Expand Down Expand Up @@ -1105,11 +1105,17 @@ spec:
"-shell-image", "{{ .Values.tektonPipelineController.shellImage }}",
# for script mode to work with windows we need a powershell image
# pinning to nanoserver tag as of July 15 2021
"-shell-image-win", "{{ .Values.tektonPipelineController.shellImageWin }}",
"-shell-image-win", "{{ .Values.tektonPipelineController.shellImageWin }}"
# Experimental. Uncomment below to disable TaskRun and PipelineRun
# reconcilers' built-in taskRef and pipelineRef resolution procedures.
# "-experimental-disable-in-tree-resolution",
{{- range .Values.tektonPipelineController.extraArgs }}
, {{ . | quote }}
{{- end }}
]
{{- with .Values.tektonPipelineController.resources }}
resources: {{ toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config-logging
mountPath: /etc/config-logging
Expand Down
5 changes: 5 additions & 0 deletions charts/tektoncd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ tektonPipelineController:
gsutilImage: gcr.io/google.com/cloudsdktool/cloud-sdk@sha256:27b2c22bf259d9bc1a291e99c63791ba0c27a04d2db0a43241ba0f1f20f4067f
shellImage: gcr.io/distroless/base:debug
shellImageWin: mcr.microsoft.com/powershell:nanoserver@sha256:b6d5ff841b78bdf2dfed7550000fd4f3437385b8fa686ec0f010be24777654d6
extraArgs: []
resources: {}

tektonPipelineWebhook:
image: gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/webhook:v0.28.0@sha256:f19dd16303ff8a8d55d706db5c8f8db593ba597684888bb15e70420fc4824103
Expand Down Expand Up @@ -83,3 +85,6 @@ configDefaults:
# but that a TaskRun does not explicitly provide.
# default-task-run-workspace-binding: |
# emptyDir: {}
featureFlags:
scopeWhenExpressionsToTask: "true"

0 comments on commit c1a9d81

Please sign in to comment.