Skip to content

Commit

Permalink
ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.
Browse files Browse the repository at this point in the history
The cited commit fixed missing mirror packets by reset mirror when
packets are modified but setting geneve options was also treated as
a modified packet but should be treated as a part of set_tunnel
which doesn't reset mirror.

Fixes: feed7f6 ("ofproto-dpif-upcall: Mirror packets that are modified.")
Acked-by: Simon Horman <horms@ovn.org>
Signed-off-by: Roi Dayan <roid@nvidia.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Simon Horman <horms@ovn.org>
  • Loading branch information
roidayan authored and Simon Horman committed Jul 17, 2024
1 parent 9f6f9aa commit a4f3079
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ofproto/ofproto-dpif-xlate.c
Original file line number Diff line number Diff line change
Expand Up @@ -7101,7 +7101,7 @@ reset_mirror_ctx(struct xlate_ctx *ctx, const struct flow *flow,

set_field = ofpact_get_SET_FIELD(a);
mf = set_field->field;
if (mf_are_prereqs_ok(mf, flow, NULL)) {
if (mf_are_prereqs_ok(mf, flow, NULL) && !mf_is_tun_metadata(mf)) {
ctx->mirrors = 0;
}
return;
Expand Down

0 comments on commit a4f3079

Please sign in to comment.