Elastic Horovod on Spark auto-scale #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
force-pushed
the
branch-elastic-spark-auto-scale
branch
3 times, most recently
from
171c508 to
3910088
Compare
EnricoMi
force-pushed
the
branch-elastic-spark-auto-scale
branch
from
3910088 to
9e791b7
Compare
This was referenced May 28, 2020
EnricoMi
force-pushed
the
branch-elastic-spark-auto-scale
branch
2 times, most recently
from
7e544be to
45c8fd0
Compare
EnricoMi
changed the title
This was referenced Jun 16, 2020
tgaddair
approved these changes
Jun 24, 2020
| @@ -194,14 +194,31 @@ def wait_for_initial_registration(self, timeout): | |||
| self._wait_cond.release() | |||
|
|
|||
| def wait_for_command_start(self, timeout=None): | |||
| """Waits for a command to start. | |||
There was a problem hiding this comment.
The overloaded behavior is a little tricky to follow. I would consider breaking this out into two methods: one that raises an exception and takes a Timeout object, and another that takes a numerical value and returns the state at the end of the timeout.
There was a problem hiding this comment.
You are right, this is horrible. I have split it up into two methods. Thanks!
EnricoMi
force-pushed
the
branch-elastic-spark-auto-scale
branch
4 times, most recently
from
8d06549 to
448501f
Compare
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
…sting Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
branch-elastic-spark-auto-scale
branch
from
448501f to
f69a110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2063.