Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ray] fix executable cls #2510

Merged
merged 4 commits into from
Dec 15, 2020
Merged

[ray] fix executable cls #2510

merged 4 commits into from
Dec 15, 2020

Conversation

richardliaw
Copy link
Collaborator

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Executable class for Ray wasn't working properly (needed for ludwig).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@richardliaw
fix-executable
9879ba2 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
cls
f87f799 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
tgaddair
tgaddair approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@richardliaw richardliaw marked this pull request as ready for review December 10, 2020 00:19
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@richardliaw
Copy link
Collaborator Author

Hmm, looks like the test failed on something unrelated?

@tgaddair
Copy link
Collaborator

Hmm, looks like the test failed on something unrelated?

Rerunning the test.

@github-actions

This comment has been minimized.

Sign in to view
@tgaddair tgaddair merged commit d8bd986 into horovod:master Dec 15, 2020
@github-actions
Copy link

Unit Test Results

   483 files  +  18     483 suites  +18   4h 10m 13s ⏱️ + 5m 32s
   534 tests +    1     503 ✔️  -     1       29 💤 ±    0  2 ❌ +2 
9 751 runs  +353  7 752 ✔️ +235  1 997 💤 +116  2 ❌ +2 

For more details on these failures, see this check.

Results for commit d8bd986. ± Comparison against base commit 2fdea15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardliaw @tgaddair