Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set model.eval() in TorchEstimator before return #2517

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Conversation

thuningxu
Copy link
Collaborator

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

TorchEstimator currently returns a model without switching to eval mode. This PR fixes that.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@github-actions

This comment has been minimized.

@tgaddair tgaddair merged commit 2fdea15 into master Dec 11, 2020
@tgaddair tgaddair deleted the nx/torch-eval branch December 11, 2020 15:36
@github-actions
Copy link

Unit Test Results

   465 files  +   179     465 suites  +179   4h 4m 41s ⏱️ + 1h 36m 45s
   533 tests ±       0     504 ✔️ +     38       29 💤  -   36  0 ❌  - 2 
9 398 runs  +3 530  7 517 ✔️ +3 058  1 881 💤 +476  0 ❌  - 4 

Results for commit 2fdea15. ± Comparison against base commit e94d8ea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants