Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimator: print trainer parameters to stdout #3049

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

chongxiaoc
Copy link
Collaborator

@chongxiaoc chongxiaoc commented Jul 20, 2021

For torch and keras trainer. Lightning trainer has already supported.

Signed-off-by: Chongxiao Cao chongxiaoc@uber.com

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

For torch and keras trainer. Lightning trainer has already supported.

Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
@chongxiaoc chongxiaoc requested a review from tgaddair July 20, 2021 05:25
@tgaddair tgaddair merged commit e36774e into horovod:master Jul 20, 2021
@github-actions
Copy link

Unit Test Results

     797 files  ±0       797 suites  ±0   6h 44m 58s ⏱️ ±0s
     629 tests ±0       584 ✔️ ±0       42 💤 ±0  3 ❌ ±0 
15 903 runs  ±0  12 250 ✔️ ±0  3 650 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit e36774e. ± Comparison against base commit e36774e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants