Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pytorch_lighting to 1.3.8 #3117

Merged
merged 1 commit into from
Aug 18, 2021
Merged

pin pytorch_lighting to 1.3.8 #3117

merged 1 commit into from
Aug 18, 2021

Conversation

chongxiaoc
Copy link
Collaborator

Fix compatibility for torch==1.4.0

Signed-off-by: Chongxiao Cao chongxiaoc@uber.com

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

Fix compatibility for torch==1.4.0

Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
@github-actions
Copy link

github-actions bot commented Aug 18, 2021

Unit Test Results

     741 files  ±0       741 suites  ±0   6h 33m 51s ⏱️ ±0s
     693 tests ±0       650 ✔️ ±0       43 💤 ±0  0 ❌ ±0 
16 485 runs  ±0  11 662 ✔️ ±0  4 823 💤 ±0  0 ❌ ±0 

Results for commit 9378ca5. ± Comparison against base commit 9378ca5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit 9378ca5 into horovod:master Aug 18, 2021
@github-actions
Copy link

github-actions bot commented Aug 18, 2021

Unit Test Results (with flaky tests)

     819 files  ±0       819 suites  ±0   6h 47m 39s ⏱️ ±0s
     693 tests ±0       651 ✔️ ±0       42 💤 ±0  0 ❌ ±0 
18 399 runs  ±0  12 862 ✔️ ±0  5 537 💤 ±0  0 ❌ ±0 

Results for commit 9378ca5. ± Comparison against base commit 9378ca5.

♻️ This comment has been updated with latest results.

@EnricoMi
Copy link
Collaborator

@chongxiaoc sorry, this still fails on GPU: https://buildkite.com/horovod/horovod/builds/6387

@chongxiaoc
Copy link
Collaborator Author

ok, that's logging function issue.
Let me create a ticket to track.

@chongxiaoc
Copy link
Collaborator Author

here: #3119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants