Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant ptx generation for maximum specififed compute capability #3509

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

trevor-m
Copy link
Contributor

Use

-gencode=arch=compute_xy,code=\"sm_xy,compute_xy\"

instead of

-gencode=arch=compute_xy,code=compute_xy
-gencode=arch=compute_xy,code=sm_xy

for the highest arch, which avoids generating ptx a second time. This slightly improves nvcc compilation time.

Signed-off-by: Trevor Morris <tmorris@nvidia.com>
@github-actions
Copy link

Unit Test Results

     763 files  +  28       763 suites  +28   8h 34m 39s ⏱️ + 12m 40s
     768 tests ±    0       678 ✔️ ±    0       90 💤 ±    0  0 ±0 
17 698 runs  +738  12 663 ✔️ +468  5 035 💤 +270  0 ±0 

Results for commit 4b4b4bf. ± Comparison against base commit 98db066.

@github-actions
Copy link

Unit Test Results (with flaky tests)

     867 files  +  46       867 suites  +46   9h 5m 29s ⏱️ + 11m 38s
     768 tests ±    0       678 ✔️ ±    0       90 💤 ±    0  0 ±0 
20 226 runs  +980  14 119 ✔️ +512  6 107 💤 +468  0 ±0 

Results for commit 4b4b4bf. ± Comparison against base commit 98db066.

@maxhgerlach maxhgerlach self-requested a review April 21, 2022 15:51
Copy link
Collaborator

@maxhgerlach maxhgerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @trevor-m!

Test failures for framework head versions are unrelated and already fixed on master.

nvcc docs show a slightly different syntax code=[sm_xy,compute_xy], but code=\"sm_xy,compute_xy\" works just the same. https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#extended-notation

@maxhgerlach maxhgerlach merged commit a77e959 into horovod:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants