Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-594: Schema registry ranger plugin #650

Merged
merged 90 commits into from
Feb 26, 2020
Merged

ISSUE-594: Schema registry ranger plugin #650

merged 90 commits into from
Feb 26, 2020

Conversation

vomoshkovskyi
Copy link
Contributor

@vomoshkovskyi vomoshkovskyi commented Jan 13, 2020 •
edited by raju-saravanan
Loading

Fixes #594

@raju-saravanan raju-saravanan changed the title Schema registry ranger plugin ISSUE-594: Schema registry ranger plugin Jan 24, 2020
raju-saravanan
raju-saravanan reviewed Feb 2, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left first round of comments

conf/registry.yaml Outdated Show resolved Hide resolved
common/src/main/java/com/hortonworks/registries/common/AuthMethodConfiguration.java Show resolved Hide resolved
common/src/main/java/com/hortonworks/registries/common/AuthMethodConfiguration.java Show resolved Hide resolved
...nt/src/main/java/com/hortonworks/registries/schemaregistry/authorizer/AuthorizerFactory.java Show resolved Hide resolved
...nt/src/main/java/com/hortonworks/registries/schemaregistry/authorizer/AuthorizerFactory.java Outdated Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Outdated Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Outdated Show resolved Hide resolved
@raju-saravanan
Copy link
Collaborator

@guruchai and @kamalcph: It will be good have your comments for this.

raju-saravanan
raju-saravanan reviewed Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more comments

...rc/test/java/com/hortonworks/registries/schemaregistry/authorizer/AuthorizerFactoryTest.java Show resolved Hide resolved
...om/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgentTest.java Outdated Show resolved Hide resolved
...est/java/com/hortonworks/registries/schemaregistry/authorizer/agent/util/TestAuthorizer.java Show resolved Hide resolved
...est/java/com/hortonworks/registries/schemaregistry/authorizer/agent/util/TestAuthorizer.java Show resolved Hide resolved
...est/java/com/hortonworks/registries/schemaregistry/authorizer/agent/util/TestAuthorizer.java Outdated Show resolved Hide resolved
...om/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgentTest.java Show resolved Hide resolved
...om/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgentTest.java Show resolved Hide resolved
...rks/registries/schemaregistry/authorizer/ranger/shim/RangerSchemaRegistryAuthorizerTest.java Show resolved Hide resolved
...tonworks/registries/schemaregistry/authorizer/ranger/RangerSchemaRegistryAuthorizerImpl.java Outdated Show resolved Hide resolved
...rizer/ranger-plugin/ranger-authorizer/src/test/resources/ranger-schema-registry-security.xml Show resolved Hide resolved
@vomoshkovskyi vomoshkovskyi force-pushed the schema-registry-ranger-plugin branch from c3d2438 to 551563f Compare February 5, 2020 15:52
raju-saravanan
raju-saravanan reviewed Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments

...c/main/java/com/hortonworks/registries/schemaregistry/webservice/SchemaRegistryResource.java Outdated Show resolved Hide resolved
...c/main/java/com/hortonworks/registries/schemaregistry/webservice/SchemaRegistryResource.java Outdated Show resolved Hide resolved
...ain/java/com/hortonworks/registries/schemaregistry/webservice/LocalSchemaRegistryServer.java Outdated Show resolved Hide resolved
raju-saravanan
raju-saravanan reviewed Feb 9, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more comments.

...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Outdated Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Outdated Show resolved Hide resolved
...main/java/com/hortonworks/registries/schemaregistry/authorizer/agent/AuthorizationUtils.java Outdated Show resolved Hide resolved
...va/com/hortonworks/registries/schemaregistry/authorizer/agent/DefaultAuthorizationAgent.java Outdated Show resolved Hide resolved
...main/java/com/hortonworks/registries/schemaregistry/authorizer/agent/AuthorizationAgent.java Outdated Show resolved Hide resolved
schema-registry/authorizer/authorization-agent/pom.xml Outdated Show resolved Hide resolved
...core/src/main/java/com/hortonworks/registries/schemaregistry/authorizer/core/Authorizer.java Show resolved Hide resolved
.../src/test/java/com/hortonworks/registries/schemaregistry/authorizer/core/AuthorizerTest.java Show resolved Hide resolved
...core/src/main/java/com/hortonworks/registries/schemaregistry/authorizer/core/Authorizer.java Show resolved Hide resolved
schema-registry/authorizer/ranger-plugin/ranger-authorizer/pom.xml Outdated Show resolved Hide resolved
guruchai
guruchai reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@guruchai guruchai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a README providing the details of authorization with an intro to the modules you are introducing?

...tonworks/registries/schemaregistry/webservice/ConfluentSchemaRegistryCompatibleResource.java Outdated Show resolved Hide resolved
...tonworks/registries/schemaregistry/webservice/ConfluentSchemaRegistryCompatibleResource.java Outdated Show resolved Hide resolved
...tonworks/registries/schemaregistry/webservice/ConfluentSchemaRegistryCompatibleResource.java Outdated Show resolved Hide resolved
...tonworks/registries/schemaregistry/webservice/ConfluentSchemaRegistryCompatibleResource.java Outdated Show resolved Hide resolved
...onworks/registries/schemaregistry/authorizer/ranger/shim/RangerSchemaRegistryAuthorizer.java Show resolved Hide resolved
...c/main/java/com/hortonworks/registries/schemaregistry/webservice/SchemaRegistryResource.java Show resolved Hide resolved
...main/java/com/hortonworks/registries/schemaregistry/authorizer/agent/AuthorizationUtils.java Outdated Show resolved Hide resolved
registry-dist/src/main/assembly/binary.xml Outdated Show resolved Hide resolved
bin/registry-server-start.sh Outdated Show resolved Hide resolved
@vomoshkovskyi vomoshkovskyi force-pushed the schema-registry-ranger-plugin branch from b519618 to b0aad82 Compare February 10, 2020 09:16
@hortonworks hortonworks deleted a comment from vomoshkovskyi Feb 11, 2020
@guruchai
Copy link
Contributor

LGTM....

raju-saravanan
raju-saravanan approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vomoshkovskyi
More detailed message when authorization exception is thrown
1082078
@vomoshkovskyi
Licence headers are added to all new files
d835d27
@vomoshkovskyi
Some codereview changes
5685781
@vomoshkovskyi
Refactoring: Authorizer resources are added, Access types are represe…
f093218 
…nted as enums, authorizer-shim module is refactored
@vomoshkovskyi
Some structural refactoring
908f0eb
@vomoshkovskyi
Factory method is added to specify Authorizer.
8c8a72b
@vomoshkovskyi
Some refactoring
3d393ed
@vomoshkovskyi
Authorization agent refactoring
a45d19b
@vomoshkovskyi
Tests for AuthorizerFactory and AuthorizationAgentFactory
85698c9
@vomoshkovskyi
Test utils for authorization-agent module
19688e7
@vomoshkovskyi
DefaultAuthorizationAgent tests and some refactoring
07d6718
@vomoshkovskyi
more test cases for DefaultAuthorizationAgent
571245b
@vomoshkovskyi
NOT_FOUND test cases for DefaultAuthorizationAgent
7a0874c
@vomoshkovskyi
Some refactoring
589966b
@vomoshkovskyi
Sanity check tests for authorizer-shim module
2510ce1
@vomoshkovskyi
Test for registryResource2RangerResource
ff713f0
@vomoshkovskyi
Authorizer core test cases
bbde580
@vomoshkovskyi
Authorizer core test cases and some refactoring
73a2e53
@vomoshkovskyi
Fix for NPE when dummy athorization agent is used
4d120fb
@vomoshkovskyi
Changes required by first round of code review
de9e072
@vomoshkovskyi
Java doc is added
b2e76cb
@vomoshkovskyi
Refactoring of factory methods
c7a060a
@vomoshkovskyi
Code review changes (Part 2)
0e1f90d
@vomoshkovskyi
Fixes for getAggregatedBranches
370d621
@vomoshkovskyi
More codereview fixes
88d6009
@vomoshkovskyi
Another code review fixes
06a88d8
@vomoshkovskyi
More code review updates
0f1916c
@vomoshkovskyi
Minor fixes after end2end testing
d7a0c6a
@vomoshkovskyi vomoshkovskyi force-pushed the schema-registry-ranger-plugin branch from cfc0f14 to d7a0c6a Compare February 24, 2020 17:15
@raju-saravanan raju-saravanan merged commit 04f49b0 into hortonworks:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guruchai guruchai guruchai left review comments

@raju-saravanan raju-saravanan raju-saravanan approved these changes

@kamalcph kamalcph Awaiting requested review from kamalcph

Assignees

@raju-saravanan raju-saravanan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ranger integration with Schema Registry
3 participants
@vomoshkovskyi @raju-saravanan @guruchai