Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verify-contracts script #146

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

EjembiEmmanuel
Copy link
Contributor

Description

This PR adds smart contracts verification feature using snfoundry/walnut

Additional Information

Copy link

vercel bot commented Aug 28, 2024

@EjembiEmmanuel is attempting to deploy a commit to the Horus Labs Team on Vercel.

A member of the Team first needs to authorize it.

Readme.md Outdated
To verify your smart contracts, from the base repository run:

```
npm run verify-contracts --contract-address=<CONTRACT_ADDRESS> --contract-name=<CONTRACT_NAME>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add this command to the documentation in docs folder. chapter 5 on scripts

package.json Outdated
@@ -7,6 +7,7 @@
"build-contracts": "cd contracts && scarb build",
"test-contracts": "cd contracts && snforge test",
"format-contracts": "cd contracts && scarb fmt",
"verify-contracts": "cd contracts && sncast verify --contract-address ${npm_config_contract-address} --contract-name ${npm_config_contract-name} --verifier walnut --network mainnet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the verifier supported on testnet? if yes can we make it possible to also verify contracts on testnet too? by making the network value passed in by users

@Darlington02 Darlington02 merged commit be9b247 into horuslabsio:main Aug 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants