Fixed the Deploy Contract[Starknet/ReactJs] #64
Conversation
…for Scaffold Deployer
…for Scaffold Deployer
|
@KodeSage is attempting to deploy a commit to the argentlabs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hi @KodeSage please address the following comments, and I'd merge your changes
| @@ -1,6 +1,5 @@ | |||
| #[starknet::contract] | |||
| mod Account { | |||
|
|
|||
There was a problem hiding this comment.
what change was made here? if not necessary, could you please undo?
There was a problem hiding this comment.
Hi @Darlington02 , no not at all o
| if (!isConnected || !account) { | ||
| throw new Error("Connect wallet to continue"); | ||
| } | ||
| // if(constructorArguments === ("" || null)){ |
There was a problem hiding this comment.
code looks a bit messy, please clear up comments/unused codes
| @@ -5,6 +5,10 @@ import trash from "../../../../public/assets/deleteIcon.svg"; | |||
| import { useRef, useState } from "react"; | |||
| import Header from "../Header"; | |||
| import Image from "next/image"; | |||
| import { UniversalDeployerContractPayload, provider , CallData} from "starknet"; | |||
| import { useAccount,useProvider } from "@starknet-react/core"; | |||
There was a problem hiding this comment.
Add a space between useAccount and useProvider
| @@ -100,24 +140,36 @@ function ScaffoldDeployer() { | |||
| Declare | |||
There was a problem hiding this comment.
work on ensuring codes are aligned properly:)
| /> | ||
| <input | ||
| {/* <input |
There was a problem hiding this comment.
please ensure to uncomment the input boxes for taking in the constructor argument and no. of constructor arguments. deploying with constructor arguments will be addressed in another issue
| @@ -0,0 +1,15 @@ | |||
| // import { | |||
There was a problem hiding this comment.
Delete this wallet.service.ts file, seems to have no use.
Description
_Concise and detailed description of proposed changes.
Additional Information
Related Issues
_Closes #45
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.