Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Move common resources to core module #192

Open
noorejannat opened this issue Feb 15, 2018 · 0 comments
Open

[General] Move common resources to core module #192

noorejannat opened this issue Feb 15, 2018 · 0 comments
Assignees
@hossain-khan
Labels
enhancement maintenance
Milestone
v3.0

Comments

@noorejannat
Copy link
Collaborator

Move strings, dimensions and icons to core module so that it can be shared by mobile and tv module.
@noorejannat noorejannat added this to the v3.0 milestone Feb 15, 2018
hossain-khan added a commit that referenced this issue Feb 15, 2018
@hossain-khan
[REFACTOR] [#192] Moved color resource to core modue.
b36284b
hossain-khan added a commit that referenced this issue Feb 15, 2018
@hossain-khan
[REFACTOR] [#192] Moved colors from mobile to core.
9096606
hossain-khan added a commit that referenced this issue Feb 15, 2018
@hossain-khan
[REFACTOR] [#192] Moved dimens to common res file.
aa858f8 
Also renamed all files in `core` to have `common_` prefix.
hossain-khan added a commit that referenced this issue Feb 15, 2018
@hossain-khan
[REFACTOR] [#192] Moved category resource to common strings res.
1b1efe9
hossain-khan added a commit that referenced this issue Feb 15, 2018
@hossain-khan
[REFACTOR] [#192] Moved font family spec to core
a6d4035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hossain-khan hossain-khan

Labels
enhancement maintenance
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@hossain-khan @noorejannat