-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unnecessary TypeScript as
#220
chore: remove unnecessary TypeScript as
#220
Conversation
LGTM, but actions failed, I don't know why. Also, I fixed one of them. |
Thank you. I don't know either, they seem to work fine locally. It also seems to be an issue in master https://github.com/hosseinmd/prettier-plugin-jsdoc/actions/runs/7180581677/job/19553161503. |
It's because of an update in prettier, https://prettier.io/blog/2023/11/13/curious-ternaries |
Hmm, this is weird, the github actions workflow file says to try installing a 3.0.x prettier version, but the one that got installed was 3.1.1 which includes the new formatting changes: https://github.com/hosseinmd/prettier-plugin-jsdoc/actions/runs/7180599499/workflow?pr=220#L17 https://github.com/hosseinmd/prettier-plugin-jsdoc/actions/runs/7180599499/job/19553214222?pr=220#step:6:16 |
Are there any options for disabling that? |
I just noticed that yarn is installing - prettier: [3.0]
+ prettier: ["3.0"] |
See #221 |
Merged, Thanks. |
The presence of this issue in Prettier has unfortunately hindered our ability to test several older versions. |
Nice ✨ |
Thank you. |
I read through some of the code and found some TypeScript
as
statements that seemed unnecessary. You'll of course decide for yourself if you want to do this change. No changes were done to the runtime JS code.