Add support for Git::Hooks 2.0.0 #2
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git::Hooks version 2.0.0 introduced some incompatible changes that must be dealt with. In particular, the hooks now receive a Git::Repository object instead of a Git::More object. The Git::More::command method can usually be replaced by the Git::Repository::run method, but it's used only once in this plugin and it can be better replaced by the 'filter_files_in_index' method, which was provided by Git::More and is now provided by Git::Repository (with the Git::Repository::Plugin::GitHooks plugin). Hence, the new version should work with any version of Git::Hooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just released a TRIAL version 2.0.0 of Git::Hooks which introduces some incompatible changes.
I think your plugin needs just a small change to make it compatible with any version of Git::Hooks. I haven't tested it though...