Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade en re-add UnusedUses sniff #52

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Upgrade en re-add UnusedUses sniff #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b716d5
Upgrade mediawiki-codesniffer and slevomat/coding-standard
janlam7 Dec 23, 2019
0e67106
Re-add UnusedUses sniff to HostnetExperimental (autofixer disabled)
janlam7 Dec 23, 2019
b814564
End php 7.1 support
janlam7 Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
language: php

php:
- 7.1
- 7.2
- 7.3
- nightly
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"description": "PHP_CodeSniffer tokenises PHP, JavaScript and CSS files and detects violations of a defined set of coding standards. Hostnet version",
"license": "MIT",
"require": {
"php": ">=7.1",
"php": ">=7.2",
"composer-plugin-api": "^1.0.0",
"hostnet/path-composer-plugin-lib": "^1.0.2",
"mediawiki/mediawiki-codesniffer": "^26.0.0",
"slevomat/coding-standard": "^4.6.0",
"mediawiki/mediawiki-codesniffer": "^28.0.0",
"slevomat/coding-standard": "^5.0.4",
"squizlabs/php_codesniffer": "^3.4.2",
"symfony/filesystem": "^3.0.2|^4.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/Hostnet/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing"/>

<!-- Forbid empty lines around type declarations -->
<rule ref="SlevomatCodingStandard.Types.EmptyLinesAroundTypeBraces">
<rule ref="SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces">
<properties>
<property name="linesCountAfterOpeningBrace" value="0"/>
<property name="linesCountBeforeClosingBrace" value="0"/>
Expand Down
6 changes: 6 additions & 0 deletions src/HostnetExperimental/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
<rule ref="Hostnet"/>
<rule ref="Squiz.Strings.DoubleQuoteUsage.NotRequired" />
<rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility"/>
<rule ref="SlevomatCodingStandard.Namespaces.UnusedUses">
<exclude phpcbf-only="true" name="SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse"/>
<properties>
<property name="searchAnnotations" value="true"/>
</properties>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint"/>
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingPropertyTypeHint"/>
Expand Down